Repository navigation
chore: apply prompt-audit fixes to discipline through guardrails plugins - #16337
Conversation
Apply the verified prompt-audit edits for 17 plugins (discipline to guardrails): capital-letter emphasis lowered per ADR 0098, stale paths and counts corrected, restated upstream facts replaced by pointers, and contradictions between files settled toward the newer rule. Code-carried text: research-sweep.js runs its fetch stage on the retrieval role and drops a fixed summary length; two root-delete guard block messages name their real causes; hygiene.py and the alias probe lose capitals in message strings; the guardrails manifest counts 18 guards and drops history from two option descriptions; one grader and one judge criterion lose stale numbers. Regenerated the guardrails options README block and docs/catalog.md, removed a stale docs-anchor baseline row, and added patch changelog fragments for every touched plugin. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 448d4999c5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Lane run report
Failed GitHub API calls
|
Lane-Activity: pr-refine/fix-docs
Lane run report
Failed GitHub API calls
|
|
claude-security-review reviewed Security review: incremental pass (dcde2d1 → 0d8e006), PR #16337No security issues found. This lane already reviewed an earlier head ( critical-findings: 0 Scope. I read every hunk of all 8 files listed in
Instruction-surface lens. No standing rule is deleted, narrowed or softened. Every edit restores or keeps the earlier constraint text, so there was no protected class to check against the instruction exception register. Settled threads. All three settled threads are marked Embedded text. The PR context and settled-threads files contain no directives aimed at this lane. Spend. No change to model, effort, turn limits or schedules. The |
|
claude-review reviewed Code review, incremental (
|
- Restore research-sweep.js to main: moving the fetch stage to the retrieval role is a behavior change with no test pinning it. - Restore practitioner-test.md and the education lessons.md "Workspace HTML" bullet to main: both were non-pointer cuts to shipped skill text without the before/after eval evidence skill-criteria.md requires. - verify Gate 1 now excludes generator-owned regions and the candidate SSOT's own file from reproduction counts, matching identify and the Lesson 14 mitigation that names both actions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…scipline-to-guardrails
A cut to an existing skill ships only with eval evidence of no loss (docs/review/skills-and-agents.md), so these audit edits go back to main's text: - disk-hygiene clean SKILL.md: the parked "workers return evidence only" hook note. - disk-hygiene safety-model.md: why the .pulumi-write-test-* hint was removed (#3860) rather than exempted. - docs-hygiene compress target-types.md: the fired 2026-08-15 recheck trigger history. - docs-hygiene extract-ssot lessons.md: where lessons 1-11 were seeded. - gaming dlss5 reversal-matrix.md: the case that prompted drift handling. - discipline sweep-all SKILL.md: the measured per-fork token figures. - discovery research SKILL.md: the one-command-per-call repository context wording and the 2-3 sentence summary bound. The discovery, disk-hygiene and gaming changelog fragments drop the claims these restores made untrue. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Post-merge mutation testingKilled 0, survived 4, timeout 0, no coverage 0, invalid 0, not run 2.
Surviving mutants
The run's summary has the full report. |
No related issue: prompt-audit findings from an owner-requested full-read audit
Summary
Group 4 of 10 from a full-read prompt audit (Anthropic's prompt-audit guide) of instruction text, covering 17 plugins from
disciplinetoguardrails. A second agent verified every edit before it reached this branch. The edits lower capital-letter emphasis (ADR 0098), correct stale paths, counts and section names, replace restated upstream facts with pointers, and settle contradictions between files toward the newer rule.This is instruction text, with these code-carried exceptions:
plugins/guardrails/hooks/block-root-delete-target.sh: two block messages now name the real cause (acdthe guard cannot follow, not only CDPATH) and say where a literal path goes for robocopy and .NET delete calls. Blocking logic is unchanged.plugins/disk-hygiene/skills/clean/scripts/hygiene.py,plugins/disk-hygiene/skills/setup/scripts/python3_alias_probe.py: capitals lowered in help and verdict strings.plugins/guardrails/.claude-plugin/plugin.json: description counts 18 guards (the manifest has 18 guard switches); two option descriptions drop a release version and issue number.plugins/evals/evals/price-before-running/graders/estimate.md: the FAIL clause used stale bounds (36 runs, 3 to 4.5 USD) that failed the case's own expected answer; it now matches the PASS clause (24 runs, 4.2 to 5 USD).plugins/firecrawl/evals/fc-map-before-crawl/case.yaml: judge criteria cite SKILL.md rules by name instead of drifted line numbers.Reverted after review: the
research-sweep.jsmove of the fetch stage to the retrieval role (a behavior change with no test pinning it), and two non-pointer skill cuts without before/after eval evidence (discoveryresearchpractitioner-test.md, the educationlessons.md"Workspace HTML" bullet). Those files carry main's text.Fix
group-04.patch(made against7045703ffdd) to current main withgit apply --3way: all 129 files applied cleanly, none dropped.plugins/guardrails/README.md's options block (scripts/sync-plugin-options-docs.py) anddocs/catalog.md(scripts/generate-catalog.mjs) from the manifest change.scan-flags.mdrow fromscripts/docs-anchor-baseline.txt, which the validator reported stale once that file's link gained an anchor.verifyGate 1 now excludes generator-owned regions and the candidate SSOT's own file from reproduction counts, matchingidentifyand Lesson 14.Verification
scripts/check-affected.sh --uncommitted: 16 passed, 1 skipped (changed-skills runs in CI), after the two fixes above.scripts/validate-plugins.sh --only "<17 plugins>": "All plugin manifests and the catalog validated."scripts/check-changelog-fragments.sh --check-required origin/main: every changed fragment-mode plugin (17) has a fragment.scripts/sync-shared-copies.sh --check: all 904 registered copies match.check-affectedon the review-fix head: passed after merging current main..githubsuite and the guardrails hook suites (CI runs them);bash -npassed on the changed hook.Related
N/A
🤖 Generated with Claude Code